Skip to content

Show that we allow CURL constant names #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2016
Merged

Show that we allow CURL constant names #106

merged 2 commits into from
Jun 30, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 29, 2016

dbu
dbu reviewed Jun 30, 2016
View reviewed changes
integrations/symfony-bundle.rst
@@ -91,7 +91,8 @@ You can configure your clients with default options. These default values will b
acme:
factory: 'httplug.factory.curl'
config:
78: 4 #CURLOPT_CONNECTTIMEOUT
CURLOPT_CONNECTTIMEOUT: 4
CURLOPT_SSL_VERIFYHOST: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use true or false for verifyhost? feels very odd to use 0 and 1. even if the underlying C library probably does that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. You are correct

@dbu
Copy link
Contributor

dbu commented Jun 30, 2016

good point!

@sagikazarmark
Copy link
Member

LGTM, thanks. Merge whenever the related PR is ready.

@dbu dbu merged commit f9cf8e1 into master Jun 30, 2016
@dbu dbu deleted the Nyholm-curl branch June 30, 2016 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @dbu @sagikazarmark